PAC-ROM logo
  • ¡Welcome to the PAC-ROM Forum!
  • Don't forget to follow us on Google+, Facebook, or Twitter!
  • Hi , Your primary usergroup is: Guests
Hello There, Guest! Login Register


Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Changing lock screen wallpaper
#1
When changing lock screen wallpaper to custom image, it did not work. Then, tried color option, and I got a systemui fc that could not be stopped. I had to restore a different Rom completely, because reflashing did nothing.

On 7-13 nightly. Sorry if already posted, but I'm on my phone now, and am on the run.
 
Reply
#2
Did some digging around, since I enjoy using custom wallpaper on lockscreen myself.

Original CM bug report: https://jira.cyanogenmod.org/browse/CYAN-1280
Custom lockscreen wallpaper also breaks after the commit of http://review.cyanogenmod.org/#/c/43630/,
revert of said patch was abandoned, and commit of http://review.cyanogenmod.org/#/c/43919/ the next days seems to fix the issue.

The same patches submitted to PAC-man gerrit in the wrong order:
http://review.pac-rom.com/#/c/245/ on Jun 8 (Merged on Jul 8, then reverted due to breaking build)
http://review.pac-rom.com/#/c/478/ on Jun 29 (Merged on Jul 11)

http://review.pac-rom.com/#/c/625/ is the revert of Patch I6b8dac563136cd10b48b6fc6c0ecb2265d0e0b04,
which broke the build because android.graphics.PorterDuff was not imported into KeyguardHostView.java until after Patch I1210d208de912e7f6a1941284f1fe1ff0776ab48.

tl;dr: Probably need to revert the revert (I8aedf28d19c553023aa7939e5eca92edc4cc1cea)

EDIT: I dug around further by decompiling android.policy.jar and editing KeyguardHostView.smali to change the filter from MULTIPLY to SRC_ATOP. I can report that custom lockscreen wallpaper is working again, with the shadowed overlay.
 
Reply
#3
Wow! Awesome and timely reply! I have the 7-14 nightly downloaded. Will țry later.

Thanks!
 
Reply
#4
mcwups1 Wrote:Wow! Awesome and timely reply! I have the 7-14 nightly downloaded. Will țry later.

Thanks!

I'm using the 7-14 nightly for evita right now and the custom lockscreen wallpaper still does not work.
If you're comfortable with decompiling apk's you can fix the bug for yourself. But otherwise, you'll have to keep waiting...
 
Reply
#5
abex181 Wrote:
mcwups1 Wrote:Wow! Awesome and timely reply! I have the 7-14 nightly downloaded. Will țry later.

Thanks!

I'm using the 7-14 nightly for evita right now and the custom lockscreen wallpaper still does not work.
If you're comfortable with decompiling apk's you can fix the bug for yourself. But otherwise, you'll have to keep waiting...

No sir. In not that proficient. Just wanted to pass along the bug. You're right about the 7-14 build.

Thank you.
 
Reply
#6
I'll try to look into fixing these patches in the right order also in PAC. Sorry for the inconvenience.

Edit: It's fixed in the next nightly.

Sent from my Nexus 4 using Tapatalk 4 Beta
 
Reply
#7
The system works!
Good stuff.
 
Reply
  


Forum Jump:


Browsing: 1 Guest(s)